Stop the robots when the stop receiving packages for 1 sec #168
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bollos00
changed the title
|
@mahi97 I tested it with a match test and I think this pull request is ready for review now. One question, should I change something on the piece of code complained bu the CodeFactor? |
|
@g3force this pull request is open for quite some time now... do I need to change anything before the pull request is merged? |
g3force
requested changes
Feb 14, 2022
|
@g3force what about now? |
|
I've fixed the pipelines on master und updated your branch to see if everything is green. Also, please use the GitHub review functions: Press the cyclic arrows to rerequest review. |
|
And please fix the CodeFactor issue. One method you modified is too complex now. Move code into a new method. |
g3force
approved these changes
Jan 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Identify the Bug
Closes #166
Description of the Change
blueControlSocket, theQElapsedTimerelapsedLastPackageBlueis restarted.MainWindow::updatewill check every time it is called ifelapsedLastPackageBluehas not been restarted for more than one second. If the condition is true, it will stop all blue robot. A similar/equivalent approach was made for theyellowControlSocket.Alternate Designs
Nothing.
Possible Drawbacks
Verification Process
Release Notes
Stop the robots when the stop receiving packages for 1 second